🐛 Fix race and an abandoned mutex #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-moore
changed the title
Octogonapus
suggested changes
Oct 24, 2019
nathan-moore
changed the title
HotelCalifornia
changed the title
|
looks good pending testing. the PR build actually finished fine, but it was unable to make the template due to some weird versioning thing |
HotelCalifornia
added
bug
|
@HotelCalifornia Seems to work fine. |
HotelCalifornia
added a commit
that referenced
this pull request
Nov 21, 2019
This reverts commit a02cefc.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Within lv_task, we were using a non atomic swap as a mutex. This changes these to be volatile/atomic where necessary. I also noticed a path where said "mutex" could be abandoned, so that's fixed as well.
Motivation:
Non deterministic races aren't fun.
References (optional):
Pointed out in purduesigbots/liblvgl#8
Test Plan: