✨Add support for extra Make scripts #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically include any firmware/*.mk scripts in Make system to allow templates to modify build process (e.g. add extra flags or dependencies).
edjubuh
force-pushed
the
feature/library-make-mods
branch
from
5d0622f to
ebecb71
Compare
edjubuh
changed the title
HotelCalifornia
added
enhancement
|
This looks good, what else is missing before a merge? |
HotelCalifornia
approved these changes
Nov 3, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Automatically include any firmware/*.mk scripts in Make system to allow
templates to modify build process (e.g. add extra flags or
dependencies).
Motivation:
A library wishes to dynamically generate a C file at Make time based on some text file and include in project's binary. There is currently no support for this. With this modification, library author creates a firmware/mylibrary.mk file which adds the corresponding variable modifications and rules to ensure the C file is generated and compiled as part of the user's project.
References (optional):
Test Plan: