Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🚸 Handle unsaved files on build #236

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

meisZWFLZ
Copy link
Contributor

@meisZWFLZ meisZWFLZ commented Oct 6, 2024

Resolves #231

  • On build, if files are unsaved, prompt user action:
    • Save unsaved files
    • Ignore message
    • Abort build
    • Don't show again
    • Enable autosave
  • Handle edge cases of vscode's autosave, by automatically saving files before if autosave is enabled
  • Improve UI
  • Implement in build and upload command too
  • Test save failure handling

On build, if files are unsaved, prompt user action
- make "Don't Show Again" work
- add "Enable Autosave"
- move permanent user actions into separate dialogue accessible with
  "More..." button
move code outside of build function into top level functions, abstractify the code, and handle save failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨Suggest Enabling Autosave
1 participant