-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ 📶 Add wireless V5 uploading #47
Conversation
Summary: tba Test Plan: tba Reviewers: O3 The Q Continuum! Tags: #zorp Differential Revision: https://phabricator.purduesigbots.com/D275
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as the actual changes made in this diff, everything looks pretty good. I just had two nits about adjacent code that might be cleared up while we're in the neighborhood.
Also, approval is contingent on the rest of the test plan being executed.
I successfully uploaded code with smart cable connection. |
This comment has been minimized.
This comment has been minimized.
#### Summary: Adds a new option for uploading binaries to the V5: ``` $ prosv5 u --compress-bin ``` The default value is true (and can be switched off with `--no-compress-bin`). When compression is enabled, .bin files to be uploaded are first compressed with gzip, which is supported natively on the V5. (there is a side change included with this PR that adds a missing letter to the name of an internally used class) #### Motivation: One of a series of PRs aimed at improving speed and reliability of wireless uploading. ##### References (optional): <!-- If this PR is related to an issue or task, reference it here (e.g. closes #1) --> Together with #46, this blocks #47 #### Test Plan: - [x] run prosv5 u (targeting a v5). bin/output.compressed.bin should be created, and it should have uploaded successfully - [x] run prosv5 u --no-compress-bin (targeting a v5). only the normal bin/output.bin should be uploaded - [x] run prosv5 u (targeting a cortex). nothing out of the ordinary should happen. Tested both with explicit `prosv5 u --compress-bin` and `prosv5 u --no-compress-bin` - [x] Test compression checkbox in interactive upload modal #### Commits * Add binary compression before uploading on V5 * Remove unused import * don't compress ini files when uploading * �� address review concerns * add interactive UI option for compression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it
Summary:
Adds support for wireless uploading. Specifically
Motivation:
Everyone and their mother wants this
Impact:
Wireless upload is slow and PROS binaries are relatively large considering the bandwidth when uploading wirelessly.
#46, purduesigbots/pros#89 all aim to address this
References (optional):
Test Plan:
/coldForkner wirelessly/coldRogers wirelesslyprosv5 lsusb
shows controller as a system port