✨✨🚸 Implement Interactive UI, migrate to sentry-sdk #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Implement interactive UI. Interactive UI is a way for the CLI to present the UI to the users and have a (possibly) external presenter worry only about presentation of the CLI's requested elements and alerting the CLI to changes to those elements. The CLI then is responsible for deciding what UI elements are needed and the relevant business logic - Migrate to new sentry-sdk which works better ™ Closes #17, #8 Test Plan: Dropdown boxes and dialog boxes don't seem to show up on the screen recorder. Not sure why, but they're there: - [X] Adding a template to a project: https://youtu.be/efV73m42bN8 - [X] Project rollback when conductor fails: https://youtu.be/EvL1wSBr4aU - [X] Creating a V5 Project: https://youtu.be/ImPsiC1aG6Q - [X] Creating a Cortex Project: https://youtu.be/7RO8LKcUf5A - [X] Upgrading an old project: https://youtu.be/2HfHUAjZO9M - [X] Installing okapilib: https://youtu.be/efV73m42bN8 - [X] Downgrading kernel and removing okapilib: https://youtu.be/t5J-j2j6QVA - [X] Sentry prompt in interactive UI: https://youtu.be/qc0FJa5BC9A - [X] Uploading a V5 project demo'ing port detection: https://youtu.be/piiRgHSsgZI Reviewers: O3 The Q Continuum! Tags: #zorp Differential Revision: https://phabricator.purduesigbots.com/D270
HotelCalifornia
approved these changes
Jan 28, 2019
3 tasks
edjubuh
added a commit
that referenced
this pull request
Feb 17, 2019
#### Summary: I broke the terminal with these changes in #38. #### Motivation: It don't work for Jonathan. I didn't observe this when testing with my install. Not sure why it's broken on Linux but not Windows. Anywho, I just reverted the changes for both platforms since it wasn't broken to begin with. ##### References (optional): N/A #### Test Plan: - [X] It work for Jonathan (on Linux) - [X] It work for me (on Windows) - [x] It work for someone else on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #17, closes #8
Test Plan:
Dropdown boxes and dialog boxes don't seem to show up on the screen recorder. Not sure why, but they're there:
Reviewers: O3 The Q Continuum!
Tags: #zorp
Differential Revision: https://phabricator.purduesigbots.com/D270