Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Apply liblvgl when upgrading to PROS 4 #345

Merged
merged 2 commits into from
May 1, 2024

Conversation

mayankpatibandla
Copy link
Member

Summary:

Automatically apply liblvgl when upgrading a PROS 3 project to PROS 4, fetch the template if necessary

Motivation:

liblvgl is needed for LLEMU on PROS 4

Test Plan:

  • Create a PROS 3 project
  • Upgrade to PROS 4
  • Ensure that liblvgl is applied
    image

@mayankpatibandla mayankpatibandla self-assigned this Apr 29, 2024
@ayushuk
Copy link
Member

ayushuk commented May 1, 2024

Not sure if I'm missing something but I pulled the latest changes on this branch and lvgl is not part of my project after running the same commands as you, let me know if the commands are wrong.

Screenshot 2024-05-01 at 11 58 34 AM

Copy link
Member

@ayushuk ayushuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comment

@mayankpatibandla
Copy link
Member Author

Not sure if I'm missing something but I pulled the latest changes on this branch and lvgl is not part of my project after running the same commands as you, let me know if the commands are wrong.

Screenshot 2024-05-01 at 11 58 34 AM

It seems you had an extra hyphen in pros c u --ea, it should be pros c u -ea

@mayankpatibandla mayankpatibandla requested a review from ayushuk May 1, 2024 18:28
Copy link
Member

@ayushuk ayushuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing, the EA flag actually triggered EA this time tho

Screenshot 2024-05-01 at 3 58 59 PM

@mayankpatibandla
Copy link
Member Author

It seems to work for me, are you sure you're on the correct branch?

On develop:

> pros c reset --force; pros c n test35 v5 3.8.3; cd test35; pros c info; pros c u -ea; pros c info 
Conductor was reset
Updating pros-mainline... Done
PROS 4 is now in early access. Please use the --early-access flag if you would like to use it.
Do you want to use PROS 4 instead? [y/N]: n
Downloading [email protected] [####################################] 100%
Extracting [email protected] [####################################] 100%
Fetched [email protected] from pros-mainline depot
Adding [email protected] to registry...Done
Applying [email protected] [####################################] 100%
Finished applying [email protected] to test35
Downloading [email protected] [####################################] 100%
Extracting [email protected] [####################################] 100%
Fetched [email protected] from pros-mainline depot
Adding [email protected] to registry...Done
Applying [email protected] [####################################] 100%
Finished applying [email protected] to test35
New PROS Project was created:
PROS Project for v5 at: C:\Projects\Robotics\PROS\pros-cli\test35 (test35)
Name      Version    Origin
--------  ---------  -------------
kernel    3.8.3      pros-mainline
okapilib  4.8.0      pros-mainline
Building project...
Creating cold package with libc,libm,libpros,okapilib [OK]
Stripping cold package  [DONE]
Section sizes:
   text    data     bss   total     hex filename
1.34MB  4.36KB  47.66MB  48.99MB 30fcba6 bin/cold.package.elf
Compiled src/main.cpp [OK]
Adding timestamp [OK]
Linking hot project with ./bin/cold.package.elf and libc,libm,libpros,okapilib [OK]
Section sizes:
   text    data     bss   total     hex filename
 1.11KB   4.00B  46.02MB  46.02MB 2e03c72 bin/hot.package.elf
Creating cold package binary for VEX EDR V5 [DONE]
Creating bin/hot.package.bin for VEX EDR V5 [DONE]
PROS Project for v5 at: C:\Projects\Robotics\PROS\pros-cli\test35 (test35)
Name      Version    Origin
--------  ---------  -------------
kernel    3.8.3      pros-mainline
okapilib  4.8.0      pros-mainline
Upgrading kernel
Updating kernel-early-access-mainline... Done
Warning! Upgrading project to PROS 4 will cause breaking changes. Do you still want to upgrade? [y/N]: y
Downloading [email protected] [####################################] 100%
Extracting [email protected] [####################################] 100%
Fetched [email protected] from kernel-early-access-mainline depot
Adding [email protected] to registry...Done
Applying [email protected] [####################################] 100%
Finished applying [email protected] to C:\Projects\Robotics\PROS\pros-cli\test35
Upgrading okapilib
Downloading [email protected] [####################################] 100%
Extracting [email protected] [####################################] 100%
Fetched [email protected] from kernel-early-access-mainline depot
Adding [email protected] to registry...Done
Applying [email protected] [####################################] 100%
Finished applying [email protected] to C:\Projects\Robotics\PROS\pros-cli\test35
PROS Project for v5 at: C:\Projects\Robotics\PROS\pros-cli\test35 (test35)
Name      Version    Origin
--------  ---------  ----------------------------
kernel    4.0.6      kernel-early-access-mainline
okapilib  5.0.0      kernel-early-access-mainline

On enhancement/liblvgl-pros4-upgrade:

> pros c reset --force; pros c n test36 v5 3.8.3; cd test36; pros c info; pros c u -ea; pros c info
Conductor was reset
Updating pros-mainline... Done
PROS 4 is now in early access. Please use the --early-access flag if you would like to use it.
Do you want to use PROS 4 instead? [y/N]: n
Downloading [email protected] [####################################] 100%
Extracting [email protected] [####################################] 100%
Fetched [email protected] from pros-mainline depot
Adding [email protected] to registry...Done
Applying [email protected] [####################################] 100%
Finished applying [email protected] to test36
Downloading [email protected] [####################################] 100%
Extracting [email protected] [####################################] 100%
Fetched [email protected] from pros-mainline depot
Adding [email protected] to registry...Done
Applying [email protected] [####################################] 100%
Finished applying [email protected] to test36
New PROS Project was created:
PROS Project for v5 at: C:\Projects\Robotics\PROS\pros-cli\test36 (test36)
Name      Version    Origin
--------  ---------  -------------
kernel    3.8.3      pros-mainline
okapilib  4.8.0      pros-mainline
Building project...
Creating cold package with libc,libm,libpros,okapilib [OK]
Stripping cold package  [DONE]
Section sizes:
   text    data     bss   total     hex filename
1.34MB  4.36KB  47.66MB  48.99MB 30fcba6 bin/cold.package.elf
Compiled src/main.cpp [OK]
Adding timestamp [OK]
Linking hot project with ./bin/cold.package.elf and libc,libm,libpros,okapilib [OK]
Section sizes:
   text    data     bss   total     hex filename
 1.11KB   4.00B  46.02MB  46.02MB 2e03c72 bin/hot.package.elf
Creating cold package binary for VEX EDR V5 [DONE]
Creating bin/hot.package.bin for VEX EDR V5 [DONE]
PROS Project for v5 at: C:\Projects\Robotics\PROS\pros-cli\test36 (test36)
Name      Version    Origin
--------  ---------  -------------
kernel    3.8.3      pros-mainline
okapilib  4.8.0      pros-mainline
Upgrading kernel
Updating kernel-early-access-mainline... Done
Warning! Upgrading project to PROS 4 will cause breaking changes. Do you still want to upgrade? [y/N]: y
Downloading [email protected] [####################################] 100%
Extracting [email protected] [####################################] 100%
Fetched [email protected] from kernel-early-access-mainline depot
Adding [email protected] to registry...Done
Applying [email protected] [####################################] 100%
Finished applying [email protected] to C:\Projects\Robotics\PROS\pros-cli\test36
Updating kernel-early-access-mainline... Done
Updating pros-mainline... Done
Downloading [email protected] [####################################] 100%
Extracting [email protected] [####################################] 100%
Fetched [email protected] from kernel-early-access-mainline depot
Adding [email protected] to registry...Done
Applying [email protected] [####################################] 100%
Finished applying [email protected] to C:\Projects\Robotics\PROS\pros-cli\test36
Upgrading okapilib
Downloading [email protected] [####################################] 100%
Extracting [email protected] [####################################] 100%
Fetched [email protected] from kernel-early-access-mainline depot
Adding [email protected] to registry...Done
Applying [email protected] [####################################] 100%
Finished applying [email protected] to C:\Projects\Robotics\PROS\pros-cli\test36
PROS Project for v5 at: C:\Projects\Robotics\PROS\pros-cli\test36 (test36)
Name      Version    Origin
--------  ---------  ----------------------------
kernel    4.0.6      kernel-early-access-mainline
liblvgl   8.3.6      kernel-early-access-mainline
okapilib  5.0.0      kernel-early-access-mainline

Copy link
Member

@ayushuk ayushuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you're right I forgot I switched branches. LGTM

@mayankpatibandla mayankpatibandla merged commit 022dc57 into develop May 1, 2024
10 checks passed
@mayankpatibandla mayankpatibandla deleted the enhancement/liblvgl-pros4-upgrade branch May 1, 2024 23:24
@ayushuk ayushuk mentioned this pull request May 7, 2024
This was referenced May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants