Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix aliases in pros v5 #333

Merged
merged 2 commits into from
Feb 16, 2024
Merged

🐛 Fix aliases in pros v5 #333

merged 2 commits into from
Feb 16, 2024

Conversation

mayankpatibandla
Copy link
Member

@mayankpatibandla mayankpatibandla commented Feb 16, 2024

Summary:

pros v5 set-variable and pros v5 read-variable are explicitly named and pros v5 set_variable and pros v5 read_variable are added as aliases.

Motivation:

The aliases for pros v5 set-variable and pros v5 read-variable are not working. #307 upgraded click which converts underscores in command names to dashes.

Test Plan:

  • pros v5 set-variable
  • pros v5 set_variable
  • pros v5 sv
  • pros v5 set
  • pros v5 read-variable
  • pros v5 read_variable
  • pros v5 rv
  • pros v5 get

Copy link
Member

@ayushuk ayushuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayankpatibandla mayankpatibandla merged commit 31ae744 into develop Feb 16, 2024
10 checks passed
@mayankpatibandla mayankpatibandla deleted the bugfix/aliases branch February 16, 2024 01:12
@ayushuk ayushuk mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants