-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Fix issue with invalid directory name check #282
Conversation
The backslash is still in the check, how were you able to create a project with it in the name? Also we should probably remove it anyways if people want to create project on windows and it does trigger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the backslash from the check
I made that mistake at first too, '\'' is the single quote character (the backslash is the escape character in this case) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I ran into this problem yesterday (it gagged on the colon, which is a problem if you're working with Windows!). Will this fix make it into the VSCode extension installation soon? Sorry for the newbie question - I started to learn PROS just yesterday and this was a big roadblock. |
Hello, thanks for trying out PROS! The bugfix is merged and we are in the process of making the release but are running into some issues. For now, you can use the pros terminal to make new projects using |
Thank you for all your great work on this project! And thanks for that tip - so long as |
Summary:
Removed "", "/", and ":" characters from check for invalid directory name when creating a project.
Motivation:
Preventing these characters from being used caused issues with using absolute file paths when creating a project.
References (optional):
Issue #278 is still unresolved
Test Plan: