-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨More Upload Options #194
Merged
Merged
✨More Upload Options #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunwarsahni01
approved these changes
Feb 2, 2022
This was referenced Feb 2, 2022
Closed
Merged
kunwarsahni01
added a commit
that referenced
this pull request
Feb 21, 2022
* 🐛 emit correct compiler for C files when generating CDB (#188) * Update Azure Pipelines with new self hosted M1 Mac (#189) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. (#190) * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. * Fix sentry-off flag * change sentry-off to no-sentry * Update Version (#186) (#191) * ✨Add Analytics (#193) * Fix and move no-sentry to default options. Setup framework for analytics * Fix some things. --toggle-analytics works * Analytics should be working. Need to figure out which commands matter * Make use-analytics a choice not a toggle * Show no-analytics flag feedback so user knows it works * Analytics appear to be working! * Reset uid to None * Compress code a bit * Remove interactive command analytics. Fix info-project typo * Move GA config to cli.pros. Fixes --use-analytics * ✨More Upload Options (#194) * Start of more upload options * Adds project icon, name, and description. Use name/description="string" * pros v5 rm-program command * rm program literals * Remove extra print messages. Kernel version = None when no project * Update Version (#186) (#195) * Update Version to 3.3.0 * 🐛Use Correct Linked Remote Name for Upload (#199) * ✨Add Icon and After support to upload_options (#200) * Change no internet exception to warning. Co-authored-by: Alex Brooke <[email protected]> Co-authored-by: BennyBot <[email protected]> Co-authored-by: Benjamin Davis <[email protected]>
kunwarsahni01
added a commit
that referenced
this pull request
May 18, 2022
* 🐛 emit correct compiler for C files when generating CDB (#188) * Update Azure Pipelines with new self hosted M1 Mac (#189) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. (#190) * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. * Fix sentry-off flag * change sentry-off to no-sentry * Update Version (#186) (#191) * ✨Add Analytics (#193) * Fix and move no-sentry to default options. Setup framework for analytics * Fix some things. --toggle-analytics works * Analytics should be working. Need to figure out which commands matter * Make use-analytics a choice not a toggle * Show no-analytics flag feedback so user knows it works * Analytics appear to be working! * Reset uid to None * Compress code a bit * Remove interactive command analytics. Fix info-project typo * Move GA config to cli.pros. Fixes --use-analytics * ✨More Upload Options (#194) * Start of more upload options * Adds project icon, name, and description. Use name/description="string" * pros v5 rm-program command * rm program literals * Remove extra print messages. Kernel version = None when no project * Update Version (#186) (#195) * Add __init__ file so ga is considered a module (#206) * Fix issue with programs uploading segfaulting/NACKing/doing nothing (#207) * ✨Set team number and robot name (#210) * Adds kv_read and kv_write functions (UNTESTED) to V5Device class * Add commands to read and set kernel variables * Add descriptions to set_variable and read_variable commands * Finish reading kernel variables. Use None for unknown rx length * Trim kernel variable value and ensure null terminated. * Move rv and sv to v5 commands * Working set command. Maximum lengths based on brain's screen space * get and set aliases * Add m as an alias for pros make. (#204) * Update Version to 3.3.2 Co-authored-by: Alex Brooke <[email protected]> Co-authored-by: BennyBot <[email protected]> Co-authored-by: Benjamin Davis <[email protected]>
kunwarsahni01
added a commit
that referenced
this pull request
May 25, 2022
* 🐛 emit correct compiler for C files when generating CDB (#188) * Update Azure Pipelines with new self hosted M1 Mac (#189) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. (#190) * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. * Fix sentry-off flag * change sentry-off to no-sentry * Update Version (#186) (#191) * ✨Add Analytics (#193) * Fix and move no-sentry to default options. Setup framework for analytics * Fix some things. --toggle-analytics works * Analytics should be working. Need to figure out which commands matter * Make use-analytics a choice not a toggle * Show no-analytics flag feedback so user knows it works * Analytics appear to be working! * Reset uid to None * Compress code a bit * Remove interactive command analytics. Fix info-project typo * Move GA config to cli.pros. Fixes --use-analytics * ✨More Upload Options (#194) * Start of more upload options * Adds project icon, name, and description. Use name/description="string" * pros v5 rm-program command * rm program literals * Remove extra print messages. Kernel version = None when no project * Update Version (#186) (#195) * Add __init__ file so ga is considered a module (#206) * Fix issue with programs uploading segfaulting/NACKing/doing nothing (#207) * ✨Set team number and robot name (#210) * Adds kv_read and kv_write functions (UNTESTED) to V5Device class * Add commands to read and set kernel variables * Add descriptions to set_variable and read_variable commands * Finish reading kernel variables. Use None for unknown rx length * Trim kernel variable value and ensure null terminated. * Move rv and sv to v5 commands * Working set command. Maximum lengths based on brain's screen space * get and set aliases * Add m as an alias for pros make. (#204) * Cleaned Up CI (#213) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Revert "✨Set team number and robot name (#210)" (#214) This reverts commit 62ee4b8. * Update Version to 3.3.3 * Update Version to 3.3.3 * Revert kernel variable read/set Co-authored-by: Kunwar Sahni <[email protected]> Co-authored-by: Alex Brooke <[email protected]>
kunwarsahni01
added a commit
that referenced
this pull request
Aug 25, 2022
* 🐛 emit correct compiler for C files when generating CDB (#188) * Update Azure Pipelines with new self hosted M1 Mac (#189) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. (#190) * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. * Fix sentry-off flag * change sentry-off to no-sentry * Update Version (#186) (#191) * ✨Add Analytics (#193) * Fix and move no-sentry to default options. Setup framework for analytics * Fix some things. --toggle-analytics works * Analytics should be working. Need to figure out which commands matter * Make use-analytics a choice not a toggle * Show no-analytics flag feedback so user knows it works * Analytics appear to be working! * Reset uid to None * Compress code a bit * Remove interactive command analytics. Fix info-project typo * Move GA config to cli.pros. Fixes --use-analytics * ✨More Upload Options (#194) * Start of more upload options * Adds project icon, name, and description. Use name/description="string" * pros v5 rm-program command * rm program literals * Remove extra print messages. Kernel version = None when no project * Update Version (#186) (#195) * Add __init__ file so ga is considered a module (#206) * Fix issue with programs uploading segfaulting/NACKing/doing nothing (#207) * ✨Set team number and robot name (#210) * Adds kv_read and kv_write functions (UNTESTED) to V5Device class * Add commands to read and set kernel variables * Add descriptions to set_variable and read_variable commands * Finish reading kernel variables. Use None for unknown rx length * Trim kernel variable value and ensure null terminated. * Move rv and sv to v5 commands * Working set command. Maximum lengths based on brain's screen space * get and set aliases * Add m as an alias for pros make. (#204) * Cleaned Up CI (#213) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Revert "✨Set team number and robot name (#210)" (#214) This reverts commit 62ee4b8. * ✨Set team number and robot name (#219) * old code (not working) * use correct txrx function * return set value * ✨Terminal file output (#220) * Added file redirect click.option to terminal.py * Got rid of indentation error * Added code for output * Redirects standard output stream to file * Outputs to both terminal and file * Modified imported modules * Added line at end * changes on windows * Update pros/cli/terminal.py for terminal file output Co-authored-by: Will Xu <[email protected]> * Removed ident error Co-authored-by: BennyBot <[email protected]> Co-authored-by: Will Xu <[email protected]> Co-authored-by: Benjamin Davis <[email protected]> Co-authored-by: Will Xu <[email protected]> Co-authored-by: BennyBot <[email protected]> Co-authored-by: Alex Brooke <[email protected]> Co-authored-by: BennyBot <[email protected]> Co-authored-by: Benjamin Davis <[email protected]> Co-authored-by: sharmaneha03 <[email protected]> Co-authored-by: Will Xu <[email protected]> Co-authored-by: Will Xu <[email protected]>
ayushuk
pushed a commit
that referenced
this pull request
Oct 19, 2022
* 🐛 emit correct compiler for C files when generating CDB (#188) * Update Azure Pipelines with new self hosted M1 Mac (#189) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. (#190) * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. * Fix sentry-off flag * change sentry-off to no-sentry * Update Version (#186) (#191) * ✨Add Analytics (#193) * Fix and move no-sentry to default options. Setup framework for analytics * Fix some things. --toggle-analytics works * Analytics should be working. Need to figure out which commands matter * Make use-analytics a choice not a toggle * Show no-analytics flag feedback so user knows it works * Analytics appear to be working! * Reset uid to None * Compress code a bit * Remove interactive command analytics. Fix info-project typo * Move GA config to cli.pros. Fixes --use-analytics * ✨More Upload Options (#194) * Start of more upload options * Adds project icon, name, and description. Use name/description="string" * pros v5 rm-program command * rm program literals * Remove extra print messages. Kernel version = None when no project * Update Version (#186) (#195) * Add __init__ file so ga is considered a module (#206) * Fix issue with programs uploading segfaulting/NACKing/doing nothing (#207) * ✨Set team number and robot name (#210) * Adds kv_read and kv_write functions (UNTESTED) to V5Device class * Add commands to read and set kernel variables * Add descriptions to set_variable and read_variable commands * Finish reading kernel variables. Use None for unknown rx length * Trim kernel variable value and ensure null terminated. * Move rv and sv to v5 commands * Working set command. Maximum lengths based on brain's screen space * get and set aliases * Add m as an alias for pros make. (#204) * Cleaned Up CI (#213) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Revert "✨Set team number and robot name (#210)" (#214) This reverts commit 62ee4b8. * Update Version to 3.3.3 * Update Version to 3.3.3 * Revert kernel variable read/set Co-authored-by: Kunwar Sahni <[email protected]> Co-authored-by: Alex Brooke <[email protected]>
kunwarsahni01
added a commit
that referenced
this pull request
Nov 14, 2022
* 🐛 emit correct compiler for C files when generating CDB (#188) * Update Azure Pipelines with new self hosted M1 Mac (#189) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. (#190) * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. * Fix sentry-off flag * change sentry-off to no-sentry * Update Version (#186) (#191) * ✨Add Analytics (#193) * Fix and move no-sentry to default options. Setup framework for analytics * Fix some things. --toggle-analytics works * Analytics should be working. Need to figure out which commands matter * Make use-analytics a choice not a toggle * Show no-analytics flag feedback so user knows it works * Analytics appear to be working! * Reset uid to None * Compress code a bit * Remove interactive command analytics. Fix info-project typo * Move GA config to cli.pros. Fixes --use-analytics * ✨More Upload Options (#194) * Start of more upload options * Adds project icon, name, and description. Use name/description="string" * pros v5 rm-program command * rm program literals * Remove extra print messages. Kernel version = None when no project * Update Version (#186) (#195) * Add __init__ file so ga is considered a module (#206) * Fix issue with programs uploading segfaulting/NACKing/doing nothing (#207) * ✨Set team number and robot name (#210) * Adds kv_read and kv_write functions (UNTESTED) to V5Device class * Add commands to read and set kernel variables * Add descriptions to set_variable and read_variable commands * Finish reading kernel variables. Use None for unknown rx length * Trim kernel variable value and ensure null terminated. * Move rv and sv to v5 commands * Working set command. Maximum lengths based on brain's screen space * get and set aliases * Add m as an alias for pros make. (#204) * Cleaned Up CI (#213) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Revert "✨Set team number and robot name (#210)" (#214) This reverts commit 62ee4b8. * ✨Set team number and robot name (#219) * old code (not working) * use correct txrx function * return set value * ✨Terminal file output (#220) * Added file redirect click.option to terminal.py * Got rid of indentation error * Added code for output * Redirects standard output stream to file * Outputs to both terminal and file * Modified imported modules * Added line at end * changes on windows * Update pros/cli/terminal.py for terminal file output Co-authored-by: Will Xu <[email protected]> * Removed ident error Co-authored-by: BennyBot <[email protected]> Co-authored-by: Will Xu <[email protected]> Co-authored-by: Benjamin Davis <[email protected]> Co-authored-by: Will Xu <[email protected]> Co-authored-by: BennyBot <[email protected]> * Fix typo in comment * add FEATURE_REQUEST.md (#230) * ✨Move Issue Template Files (#231) * Move Issue Template Files * Update BUG_REPORT.md * Create main.yml * Update main.yml * Add pyinstaller requirement * Add .spec file * Update main.yml * add universal2 arch * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * attempt fake version number * Update main.yml * Update main.yml * Update main.yml * version.py exception * Update main.yml * Try adding --always and stderr * remove --always * fetch tags to prevent name error? * Add Fetch Depth * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update requirements.txt * Remove older ci/cd files * Move to new build constants system * Basic Import structure for pyinstaller * Move back to spec file * Install wheel first * Correct constant writing * Remove old Build Constants * Add wheel building * Different Name for Wheel Artifact * Typo * Codeql Analysis * Only on dev/master for code scan * 🔖 Release 3.3.3 (#215) * 🐛 emit correct compiler for C files when generating CDB (#188) * Update Azure Pipelines with new self hosted M1 Mac (#189) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. (#190) * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. * Fix sentry-off flag * change sentry-off to no-sentry * Update Version (#186) (#191) * ✨Add Analytics (#193) * Fix and move no-sentry to default options. Setup framework for analytics * Fix some things. --toggle-analytics works * Analytics should be working. Need to figure out which commands matter * Make use-analytics a choice not a toggle * Show no-analytics flag feedback so user knows it works * Analytics appear to be working! * Reset uid to None * Compress code a bit * Remove interactive command analytics. Fix info-project typo * Move GA config to cli.pros. Fixes --use-analytics * ✨More Upload Options (#194) * Start of more upload options * Adds project icon, name, and description. Use name/description="string" * pros v5 rm-program command * rm program literals * Remove extra print messages. Kernel version = None when no project * Update Version (#186) (#195) * Add __init__ file so ga is considered a module (#206) * Fix issue with programs uploading segfaulting/NACKing/doing nothing (#207) * ✨Set team number and robot name (#210) * Adds kv_read and kv_write functions (UNTESTED) to V5Device class * Add commands to read and set kernel variables * Add descriptions to set_variable and read_variable commands * Finish reading kernel variables. Use None for unknown rx length * Trim kernel variable value and ensure null terminated. * Move rv and sv to v5 commands * Working set command. Maximum lengths based on brain's screen space * get and set aliases * Add m as an alias for pros make. (#204) * Cleaned Up CI (#213) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Revert "✨Set team number and robot name (#210)" (#214) This reverts commit 62ee4b8. * Update Version to 3.3.3 * Update Version to 3.3.3 * Revert kernel variable read/set Co-authored-by: Kunwar Sahni <[email protected]> Co-authored-by: Alex Brooke <[email protected]> * ✨Set team number and robot name (#219) * old code (not working) * use correct txrx function * return set value * ✨Terminal file output (#220) * Added file redirect click.option to terminal.py * Got rid of indentation error * Added code for output * Redirects standard output stream to file * Outputs to both terminal and file * Modified imported modules * Added line at end * changes on windows * Update pros/cli/terminal.py for terminal file output Co-authored-by: Will Xu <[email protected]> * Removed ident error Co-authored-by: BennyBot <[email protected]> Co-authored-by: Will Xu <[email protected]> Co-authored-by: Benjamin Davis <[email protected]> Co-authored-by: Will Xu <[email protected]> Co-authored-by: BennyBot <[email protected]> * Fix typo in comment * add FEATURE_REQUEST.md (#230) * ✨Move Issue Template Files (#231) * Move Issue Template Files * Update BUG_REPORT.md * ✨ Version Display On Error * Update main.yml * Update main.yml * Revert "Merge branch 'develop' of github.com:purduesigbots/pros-cli into develop" This reverts commit a3de138, reversing changes made to d953b0d. * Revert "Revert "Merge branch 'develop' of github.com:purduesigbots/pros-cli into develop"" This reverts commit 0929e41. * ✨ Run make clean after uninstall template (#244) * Run make clean after uninstall temp * Add flag * Update version to 3.4.1 Co-authored-by: Kunwar Sahni <[email protected]> Co-authored-by: Alex Brooke <[email protected]> Co-authored-by: BennyBot <[email protected]> Co-authored-by: Benjamin Davis <[email protected]> Co-authored-by: sharmaneha03 <[email protected]> Co-authored-by: Will Xu <[email protected]> Co-authored-by: Will Xu <[email protected]> Co-authored-by: niu <[email protected]> Co-authored-by: Liam Teale <[email protected]> Co-authored-by: AlexHunton2 <[email protected]> Co-authored-by: omegaStag <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds pros v5 rm-program command to remove a program from the V5 Brain.
Adds icon, name, and description options to
pros upload
commandUsage:
pros v5 rm-program 1
will remove the program on slot 1 of the connected V5 Brain.pros u --icon alien, name="Alien Project", description="A project with an alien as its icon"
will upload a project to the brain with the custom name, description, and icon provided in the command. The name and description arguments must be="<value>"
if the value contains spaces. Valid arguments for the icon option are pros (default value), pizza, planet, alien, ufo, robot, clawbot, question, X, and power.Motivation:
Close the long-overdue PR to add more upload options. Additionally, giving users the ability to choose program description, names, and icons can help them easily differentiate program versions.
References (optional):
closes #126
Test Plan: