-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Fixes CLI hanging in commands calling 'make.exe' #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillXuCodes
previously requested changes
Nov 2, 2021
@BennyBot one further test: try to build a project with no PROS_TOOLCHAIN variable but the toolchain folder is on PATH |
kunwarsahni01
approved these changes
Nov 19, 2021
kunwarsahni01
approved these changes
Nov 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously: If 'make.exe' wasn't found, the 'EchoPipes' used to communicate the build status to the user would hang.
Changes: Used try/except on the 'pros make' command and 'pros build-compile-commands' commands. If an exception is thrown when running 'make.exe', the program will close the 'EchoPipe' class(es), print an error message to the screen, print a warning IF the pros toolchain is not found, and then exit.
Motivation:
The hanging terminal got on my nerves while trying to get the toolchain installed correctly on my windows pc.
References (optional):
This may be related to #83, as calling 'make.exe' through 'build-compile-commands' would hang the CLI if any exception was thrown during that subprocess.
Test Plan:
Ran both 'pros make' and 'pros build-compile-commands' with and without the toolchain environmental variable. Acts normally if 'make.exe' is there, and exits without hanging if an error is thrown during the calling of 'make.exe'
Screenshot of non-hanging terminal after both commands fail shown below.