✨Create new project without internet

[omegaStag]

Summary:

• Added 'download-ok' switch to new-project to decide if remote templates can be used in creating projects
• Put some lines from new-project into new helper function _create_project for this purpose (and to make click happy)
• Due to a generic Exception being raised when there is no internet connection (instead of an actual ConnectionError for some reason), added a nested try and except statement to attempt a new project with local templates if remote templates cannot be reached, raises another exception if that fails
• Fixed resolved_templates so that it actually takes into account whether 'download-ok' is true or false before downloading from remote
• "Can't GitHub" error could be placed before the output telling user which templates are used, but I'm not sure how to place it as I don't want it to trigger before a potential Exception due to something that is NOT a lack of internet
• Removed allow_online: bool = True from top of resolve_templates to make above features work
• Removed allow_online=download_ok from template = self.resolve_template(identifier=identifier, allow_online=download_ok, **kwargs) because resolve_templates now takes 'download_ok' into account seperately

Motivation:

Let users make new project from local templates without internet

References (optional):

Closes #91

Test Plan:

1. (With internet) Purge templates, download 2nd most recent versions of okapilib and kernel, then run pros c n . --no-download to demonstrate that the most recent remote templates are not applied, and the local templates are used instead
   

2. (Without internet) Create a new project with pros c n .. There will be an error that alerts the user that the CLI can't connect to GitHub, and it creates a project with the local templates you have instead.
   

3. (Without internet) pros c n . --download. Even if --download is specified, if there is no internet it creates from local templates without problem.
   

4. (With internet) pros c n .. Newest versions of templates from remote are automatically downloaded and applied as usual.
   

5. (Without internet) pros c n . creates a new project with the most recent local templates.
   

[WillXuCodes]

Unless anyone else has any other comments, this seems to work and be good based on the test cases.

[edjubuh]

I'd rather just fix resolve_templates to always be OK if a remote depot is unavailable.

e.g. try block around:

pros-cli/pros/conductor/conductor.py

Lines 119 to 124 in 1d9f6ba

	online_results = filter(lambda t: t.satisfies(query, kernel_version=kernel_version),
	depot.get_remote_templates(force_check=force_refresh, **kwargs))
	if unique:
	results.update(online_results)
	else:
	results.extend(online_results)

[omegaStag]

I'd rather just fix resolve_templates to always be OK if a remote depot is unavailable.

e.g. try block around:

pros-cli/pros/conductor/conductor.py

Lines 119 to 124 in 1d9f6ba

	online_results = filter(lambda t: t.satisfies(query, kernel_version=kernel_version),
	depot.get_remote_templates(force_check=force_refresh, **kwargs))
	if unique:
	results.update(online_results)
	else:
	results.extend(online_results)

When I try to have the try in resolve_templates it generates a bunch of error messages, seemingly because it doesn't like calling itself... but makes the project anyways? I have no idea

[WillXuCodes]

I'm not seeing the try except block anywhere, have you pushed it yet? Also, what are you doing with the exception after catching it? It seems like it's just getting printed and moving on.

(not actually approving the PR)

[omegaStag]

With internet

No internet

There's not really an easy way to get rid of the duplicate warnings but I think that having them is better than not having any indication of no connection at all.

[WillXuCodes]

I'm approving this so we can get this shipped out the door a little quicker. The cosmetic issue of the warning appearing twice should be a seperate issue we open after the PR and somebody else could handle it as their entry level issue :P . Great work!

(not cosmetic apparently)