Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Improve message when creating in existing project #172

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

omegaStag
Copy link
Contributor

Summary:

Improves error message when attempting to create a project in an existing one. Improves from previous file change by telling the user the path where the existing project is located.

Motivation:

Better error message makes it less confusing for the user.

References (optional):

#44
This pull request may be redundant to this other one, but the other one is stale #51

Test Plan:

Create an empty folder, then make a new project in it. Then, attempt to make a new project again in the same folder.
image

Copy link
Member

@WillXuCodes WillXuCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen this work in person, LGTM.

@kunwarsahni01 kunwarsahni01 self-requested a review October 21, 2021 22:01
@WillXuCodes WillXuCodes merged commit b122cce into develop Oct 21, 2021
@WillXuCodes WillXuCodes deleted the enhancement/project-existing-message branch October 21, 2021 22:02
@kunwarsahni01 kunwarsahni01 mentioned this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a better error message on project creation when one already exists
3 participants