This repository has been archived by the owner on Nov 18, 2024. It is now read-only.
Add caching of STS-exchanged access tokens #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DrDaveD
force-pushed
the
cache-sts-tokens
branch
5 times, most recently
from
84bcd63 to
a96aeeb
Compare
|
I finally figured it out! This is now ready for review. |
DrDaveD
force-pushed
the
cache-sts-tokens
branch
from
a96aeeb to
50db5bf
Compare
|
Any thoughts on this? |
|
@impl Do you have any reaction to this? |
|
Hi @DrDaveD, Hope all is well! Unfortunately these days I'm pretty far removed from day-to-day work with Puppet and I don't believe there's anyone in the company actively using this plugin anymore. I'm going to archive this repository, but of course you're welcome to maintain a fork as you see fit. Thanks for all your contributions over the years! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the caching on the "creds" API, this adds caching on the "sts" API. It adds a
minimum_secondsparameter.I believe it is complete except that I haven't been able to figure out how to make the testing work. The testing mechanism is very complicated and I was hoping you could give me a little help. My latest attempt is included in this draft, maybe you can tell me what's wrong with it?