Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) - Add license file to built gem #108

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

jordanbreen28
Copy link

@jordanbreen28 jordanbreen28 commented Feb 12, 2024

Summary

Prior to this PR, the LICENSE file was not shipped with our built gem.

This PR corrects the filename in the gemspec, so that the LICENSE file is now packaged with the gem once built.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Fixes #107

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Prior to this commit, the LICENSE file was not shipped with our built
gem.

This commit corrects the filename in the gemspec, so that the LICENSE
file is now packaged with the gem once built.
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fce2e09) 86.83% compared to head (c691c5b) 86.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   86.83%   86.83%           
=======================================
  Files          35       35           
  Lines        2089     2089           
=======================================
  Hits         1814     1814           
  Misses        275      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 836e13a into main Feb 12, 2024
10 checks passed
@LukasAud LukasAud deleted the bug-add_license_to_gem branch February 12, 2024 09:40
archlinux-github pushed a commit to archlinux/aur that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rspec-puppet-4.0.2.gem doesn't contain LICENSE file, is this intentional?
3 participants