Skip to content

Commit

Permalink
(maint) Add note about container dotted env vars
Browse files Browse the repository at this point in the history
 - Both docker (per moby/moby#16585) and
   Kubernetes (per kubernetes/kubernetes#2707)
   support passing environment variables with dots as config, despite
   dot not technically being supported in POSIX.

   This is necessary to be able to specify hocon array values like
   FOO.0, FOO.1, etc now that the Hocon library is updated to
   typesafe/config 1.4.1 via puppetlabs/typesafe-config 0.2.0 /
   clj-parent 4.6.11

   /bin/sh will not add such variables to the environment, but /bin/bash
   will properly expose them, so that they may be consumed by
   puppetserver and hocon.

   NOTE: ElasticSearch is notorious for passing such values, and it also
   uses the tini init system, so it served as a good design to follow:

   https://github.com/elastic/elasticsearch/tree/master/distribution/docker
  • Loading branch information
Iristyle committed Mar 29, 2021
1 parent 1f57304 commit 99f0fe8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions docker/puppetserver/docker-entrypoint.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/bin/bash
# bash is required to pass ENV vars with dots as sh cannot

set -e

Expand Down

0 comments on commit 99f0fe8

Please sign in to comment.