Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-422) - Allow ref to be optional in fixtures #430

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Feb 1, 2024

Summary

See #422
Ref is optional in fixtures, thus can be nil. Adding the Safe Navigation Operator prevents an undefined method for Nil:nil class error

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Fixes #422

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 marked this pull request as ready for review February 1, 2024 16:31
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce3a8e2) 41.71% compared to head (b545f3f) 41.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   41.71%   41.71%           
=======================================
  Files          10       10           
  Lines         676      676           
=======================================
  Hits          282      282           
  Misses        394      394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david22swan david22swan merged commit 157ed92 into main Feb 1, 2024
10 checks passed
@david22swan david22swan deleted the gh-422-fix_nil_error_on_ref branch February 1, 2024 16:34
@jordanbreen28 jordanbreen28 changed the title (GH-422) - Add Safe Navigation Operator to hash['ref'] (GH-422) - Allow ref to be optional in fixtures Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ref option for repository fixtures is required
2 participants