Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept :tag for consistency with r10k #296

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Accept :tag for consistency with r10k #296

merged 1 commit into from
Nov 15, 2019

Conversation

binford2k
Copy link
Contributor

This is a terrible way to do this. We should actually handle real branch/tag/etc like r10k does. This is intentionally undocumented so that it will only help catch user mistakes.

This is a terrible way to do this. We should actually handle real branch/tag/etc like r10k does. This is intentionally undocumented so that it will only help catch user mistakes.
@binford2k binford2k requested a review from a team as a code owner October 31, 2019 18:30
Copy link
Collaborator

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havn't tested it, but I really don't think that it looks as bad as you think it does.

@puppetcla
Copy link

CLA signed by all contributors.

Copy link
Contributor

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavidS DavidS merged commit 4fb572b into master Nov 15, 2019
@DavidS DavidS deleted the binford2k-patch-1 branch January 18, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants