Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-1199) Honour .{pdk,git}ignore in check:symlinks rake task #267

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Dec 10, 2018

Introduces pathspec as a dependency (pure ruby and is already
a dependency of PDK and Puppet so it shouldn't be an issue). Also moves
the symlink checking logic out of the existing helper module and into
its own class for easier isolation between test cases.

Introduces pathspec as a dependency (pure ruby and is already
a dependency of PDK and Puppet so it shouldn't be an issue). Also moves
the symlink checking logic out of the existing helper module and into
its own class for easier isolation between test cases.
@codecov-io
Copy link

codecov-io commented Dec 10, 2018

Codecov Report

Merging #267 into master will increase coverage by 2.76%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   41.61%   44.37%   +2.76%     
==========================================
  Files          10       11       +1     
  Lines         757      773      +16     
==========================================
+ Hits          315      343      +28     
+ Misses        442      430      -12
Impacted Files Coverage Δ
lib/puppetlabs_spec_helper/tasks/fixtures.rb 35.04% <ø> (+0.96%) ⬆️
lib/puppetlabs_spec_helper/rake_tasks.rb 46.07% <100%> (+2.23%) ⬆️
lib/puppetlabs_spec_helper/tasks/check_symlinks.rb 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 133d4ac...eaf149a. Read the comment docs.

@puppetcla
Copy link

CLA signed by all contributors.

@bmjen bmjen merged commit f6b45e3 into puppetlabs:master Dec 10, 2018
@rodjek rodjek deleted the pdk-1199 branch December 11, 2018 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants