(MODULES-7856) Allow optional repositories based on puppet version

[joshcooper]

Some types/providers maybe missing when testing against puppet6 as a
gem. Allow an optional repository to be specified which will only be
installed if the current puppet version matches the semantic version
constraint. For example, stdlib will always be installed, but
selinux_core is only installed when testing on puppet6 or above:

repositories:
  stdlib: https://github.com/puppetlabs/puppetlabs-stdlib.git
  selinux_core:
    repo: https://github.com/puppetlabs/puppetlabs-selinux_core.git
    puppet_version: ">= 6.0.0"

[joshcooper]

Looks like it's failing on puppet 3.0 because that version doesn't depend on or vendor semantic_puppet. I'll take a look in a bit.

[bastelfreak]

can we please finally drop puppet 3? it is EOL since almost 2 years. is it even on the test mattix on purpose?

[joshcooper]

I worked around the puppet 3 issue for now (so the puppet_version attribute is ignored). But I am in favor of dropping puppet 3 from the test matrix.

[codecov-io]

Codecov Report

Merging #258 into master will increase coverage by 0.65%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
+ Coverage    39.8%   40.46%   +0.65%     
==========================================
  Files          10       10              
  Lines         726      734       +8     
==========================================
+ Hits          289      297       +8     
  Misses        437      437

Impacted Files	Coverage Δ
lib/puppetlabs_spec_helper/tasks/fixtures.rb	31.77% <100%> (+2.64%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 779738e...aa74b9c. Read the comment docs.

[joshcooper]

👍 to dropping puppet 3.x from the travis matrix.

@DavidS does this need a PDK ticket? Should I target an earlier branch?

[puppetcla]

CLA signed by all contributors.

[DavidS]

I'm happy enough to keep the puppet3 guard in there for now. It should be noted in the README though.

a couple of tests in https://github.com/puppetlabs/puppetlabs_spec_helper/blob/master/spec/unit/puppetlabs_spec_helper/tasks/fixtures_spec.rb are also needed.

[davidmalloncares]

Hey @joshcooper, would you be able to get a look at this one today around David Schmitts review comments? This change is currently causing issues for Modules teams and Vox for Puppet 6 so would be cool if we can get unblocked asap

[joshcooper]

@DavidS this should be good now

• Added a JIRA ticket
• Updated docs about puppet_version only working on Puppet 4 and up
• Reworked the code to test for the SemanticPuppet being defined, instead of relying on puppet version heuristic
• Added tests

[DavidS]

Thanks for the tests and cleanup. Looks great!