(feat) add puppet lint fix task #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| PuppetLint::RakeTask.new(:lint_fix) do |config| | ||
| config.fail_on_warnings = true | ||
| config.fix = true | ||
| config.disable_checks = [ |
There was a problem hiding this comment.
Can you add http://puppet-lint.com/checks/autoloader_layout/ to this please!
bastelfreak
reviewed
Aug 29, 2018
| 'spec/**/*.pp', | ||
| 'tests/**/*.pp', | ||
| 'types/**/*.pp', | ||
| 'vendor/**/*.pp', |
There was a problem hiding this comment.
on Vox Pupuli, we also ignore .vendor. Maybe you want to add that as well:
https://github.com/voxpupuli/modulesync_config/blob/5a7d028a95278d11c2b02616d300fda002fefa0d/moduleroot/Rakefile.erb#L22
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
========================================
+ Coverage 39.3% 39.8% +0.5%
========================================
Files 10 10
Lines 720 726 +6
========================================
+ Hits 283 289 +6
Misses 437 437
Continue to review full report at Codecov.
|
|
thanks @HelenCampbell @bastelfreak , what do you think ?? |
bastelfreak
approved these changes
Aug 29, 2018
|
CLA signed by all contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.