Rake should fail if git can't clone repository #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @carlossg, could you please rebase this onto master? It won't currently merge cleanly due to a recent merge. Thanks! |
The rspec-puppet documentation mentions than any node definitions for node tests should be placed in spec/fixtures/manifests/site.pp, but this file is uncontitionally removed by `rake spec_clean`. This commit changes that behaviour to only remove site.pp if it is empty.
|
rebased |
|
Thanks for the quick response and sorry that this didn't get reviewed sooner! It looks like your rebase also rebased some of the existing commits, so I |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for some reason git can't connect to the internet to clone the repo the build continues, maybe failing later in the specs with missing fixtures.
This patch makes it fail fast with the right message