(maint) Properly escape paths #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnduarte
approved these changes
May 31, 2017
|
@hunner or @DavidS are you the gatekeepers for this repo? |
|
@samuelson could you modify your commit message to prepend it with i.e. |
If the expanded path includes a space the puppet module tool would interpret it as additional arguments. This change adds quotes around the paths so that they're interpreted as single arguments.
samuelson
force-pushed
the
spaces_in_paths
branch
from
261f535
to
6270645
Compare
hunner
added a commit
that referenced
this pull request
May 31, 2017
If the expanded path includes a space the puppet module tool would interpret it as additional arguments. This change adds quotes around the paths so that they're interpreted as single arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the expanded path includes a space the puppet module tool would
interpret it as additional arguments. This change adds quotes around
the paths so that they're interpreted as single arguments.