(maint) fix load order for gettext-setup tasks #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> once initialization of GettextSetup was introduced to other gems, it became important to have our modules initialization come last in load order. semantic_puppet and puppet are both required in the PSH rake tasks file and were being loaded on either side of our gettext tasks, causing puppet to be loaded last and get a POT file created. This commit moves our initialization to the bottom of the rake tasks file so its loaded last and thus the POT file is once again created in the module, not in puppet or semantic_puppet. Additionally, logic is added to make sure that in the event a module does not have a locales directory, the gettext-setup tasks are not loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
once initialization of GettextSetup was introduced to other gems, it became important to have our modules initialization come last in load order. semantic_puppet and puppet are both required in the PSH rake tasks file and were being loaded on either side of our gettext tasks, causing puppet to be loaded last and get a POT file created. This commit moves our initialization to the bottom of the rake tasks file so its loaded last and thus the POT file is once again created in the module, not in puppet or semantic_puppet. Additionally, logic is added to make sure that in the event a module does not have a locales directory, the gettext-setup tasks are not loaded.