Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should use Errno, not Error #119

Merged
merged 1 commit into from
Nov 6, 2015
Merged

Should use Errno, not Error #119

merged 1 commit into from
Nov 6, 2015

Conversation

kristvanbesien
Copy link

We have a CI/CD env that automatically builds rpms from puppet modules we develop ourselves. As part of the automatic build the spec tests are performed. I noticed that after you released 1.0.0 of puppelabs_spec_helper suddenls all our spec tests started failing, all with the same error:

NameError: uninitialized constant Error
/var/lib/jenkins/.gem/gems/puppetlabs_spec_helper-1.0.0/lib/puppetlabs_spec_helper/rake_tasks.rb:41:in `rescue in fixtures'
/var/lib/jenkins/.gem/gems/puppetlabs_spec_helper-1.0.0/lib/puppetlabs_spec_helper/rake_tasks.rb:39:in `fixtures'
/var/lib/jenkins/.gem/gems/puppetlabs_spec_helper-1.0.0/lib/puppetlabs_spec_helper/rake_tasks.rb:111:in `block in <top (required)>'
/var/lib/jenkins/.gem/gems/puppetlabs_spec_helper-1.0.0/lib/puppetlabs_spec_helper/rake_tasks.rb:197:in `block in <top (required)>'
Tasks: TOP => spec_prep

I traced this to rake_tasks.rb, where I think it shoud be "Errno" and not "Error".

Note, I'm not really a Ruby expert. This is just a hunch I had, which I managed to conform through my own testing.

@garethr
Copy link

garethr commented Nov 6, 2015

@krisamundson I just hit this as well, I I've just verified this fix. Cheers. Let me find out who owns this project.

HelenCampbell pushed a commit that referenced this pull request Nov 6, 2015
@HelenCampbell HelenCampbell merged commit 8617b27 into puppetlabs:master Nov 6, 2015
@kristvanbesien kristvanbesien deleted the errnofix branch November 6, 2015 13:17
garethr added a commit to puppetlabs-toy-chest/puppetlabs-azure that referenced this pull request Nov 6, 2015
Due to puppetlabs/puppetlabs_spec_helper#119
puppetlabs_spec_helper 1.0 fails to run tasks. Pinning to a working
version until this is resolved.
@hunner
Copy link
Contributor

hunner commented Nov 6, 2015

@kristvanbesien Sorry about that. 1.0.1 pushed with this fix

@chelnak chelnak added the bug label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants