Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

declaring a symlink should not alter the default symlink to current module #397

Closed
MartyEwings opened this issue Apr 28, 2023 · 0 comments · Fixed by #431
Closed

declaring a symlink should not alter the default symlink to current module #397

MartyEwings opened this issue Apr 28, 2023 · 0 comments · Fixed by #431
Labels
bug

Comments

@MartyEwings
Copy link

This code

puppetlabs_spec_helper/lib/puppetlabs_spec_helper/tasks/fixtures.rb

Line 110 in 01886e8

fixtures['symlinks'] = auto_symlink if fixtures['symlinks'].nil?

prevents the use of symlinks section of the fixtures file for any other purpose than self reference for example:

symlinks:
peadm_spec: "#{source_dir}/spec/fixtures/modules/peadm/spec/acceptance/peadm_spec/"

would mean the code above would not also include this in the fixtures

symlinks:
<module_name>: "#{source_dir}"

It would be preferred if instead of a check and replace

fixtures['symlinks'] = auto_symlink if fixtures['symlinks'].nil?

that fixtures['symlinks'] wold be merged with auto_symlink to prevent loss of testing context
jordanbreen28 added a commit that referenced this issue Feb 1, 2024
@jordanbreen28
(GH-397) - Honour default symlink when additional symlinks delcared
eee3d6f 
Before, declaring a symlink would overwrite the symlink to the current
module.
This is not what we would want for testing, and we should be able to
declare additional symlinks to the default one.
Now, we extra symlinks declared, we merge into the auto_symlink, if not
operate as before.
@jordanbreen28 jordanbreen28 mentioned this issue Feb 1, 2024
Merged
3 tasks
jordanbreen28 added a commit that referenced this issue Feb 1, 2024
@jordanbreen28
(GH-397) - Honour default symlink when additional symlinks delcared
033e2d9 
Before, declaring a symlink would overwrite the symlink to the current
module.
This is not what we would want for testing, and we should be able to
declare additional symlinks to the default one.
Now, we extra symlinks declared, we merge into the auto_symlink, if not
operate as before.
jordanbreen28 added a commit that referenced this issue Feb 1, 2024
@jordanbreen28
(GH-397) - Honour default symlink when additional symlinks delcared
5745b70 
Before, declaring a symlink would overwrite the symlink to the current
module.
This is not what we would want for testing, and we should be able to
declare additional symlinks to the default one.
Now, we extra symlinks declared, we merge into the auto_symlink, if not
operate as before.
LukasAud added a commit that referenced this issue Feb 1, 2024
@LukasAud
Merge pull request #431 from puppetlabs/gh-397-honour_default_symlink
b2be9cc 
(GH-397) - Honour default symlink when additional symlinks delcared
LukasAud added a commit that referenced this issue Feb 9, 2024
@LukasAud
Merge pull request #435 from puppetlabs/gh-397-honour_default_symlink
e5e51a2 
(bug) - check for empty fixtures array, as well as nil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@MartyEwings