-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(L10n) Delivering translations for POT and README files #7
Conversation
2. [セットアップ - yumrepo_coreモジュール導入の基本](#setup) | ||
* [yumrepo_coreモジュールの利用方法](#beginning-with-yumrepo_core) | ||
3. [使用 - 設定オプションと追加機能](#usage) | ||
4. [開発 - モジュール貢献についてのガイド](#development) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these links work? I would think (#development)
should correspond to 開発
? (I have no idea if that's the correct section, I'm just guessing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links don't seem to work. @ehom should that be?
[開発 - モジュール貢献についてのガイド](#開発)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i looked into this issue a little more. it turns out that all links from table of contents are broken in all localized markdown files. If the section header is localized, it breaks the anchor reference. Transifex doesn't expose the anchor for localization. So, to resolve this, we'll need a post-localization step to resolve this. Will create an ticket to list all broken markdown files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ehom Should we wait to merge these modules PRs until that anchor fix is in? How long do you think that will take?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @melissa i'm waiting for a response from Transifex. Give it a day.
# SOME DESCRIPTIVE TITLE. | ||
# Copyright (C) 2018 Puppet, Inc. | ||
# This file is distributed under the same license as the puppetlabs-yumrepo_core package. | ||
# FIRST AUTHOR <EMAIL@ADDRESS>, 2018. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do these details come from? Should we change them to be something more realistic?
Closed in favor of #9 |
No description provided.