metadata: add Windows

[kenyon]

This reverts commit c3cf902.

I'm using the sshkey type on Windows with success.

[mhashizume]

Thanks for this @kenyon , I've opened a ticket internally for our team to take a look at this

[kenyon]

Done in commit c1a544b.

[AriaXLi]

Hi @kenyon, would it be possible to provide the code that uses sshkeys_core on Windows that's running successfully? From what I understand, not all features of sshkeys_core can be used on Windows, such as creating ssh authorized keys (see this failing test for more info).

[kenyon]

@AriaXLi sure, on Windows I'm just using this module to populate a known_hosts file like this:

Sshkey {
  target  => 'C:/Program Files/Git/etc/ssh/ssh_known_hosts',
  require => Package['git'],
}

include ssh::knownhosts

ssh::knownhosts is from saz/ssh: https://github.com/saz/puppet-ssh/blob/master/manifests/knownhosts.pp

So yes, maybe not all features of this module work on Windows, at least without some additional work.

[AriaXLi]

@kenyon Thanks for providing the code you used for Windows! Yeah it seems like some features don't work on Windows yet, like creating and managing ssh keys so there is more work needed than anticipated originally. Due to this, I reverted the changes made in #84. Feel free to checkout https://puppet.atlassian.net/browse/MODULES-11236 for more information.

[kenyon]

@AriaXLi yes, I'm not sure if there are guidelines on when a platform should be included in metadata.json: when some module features work, or when all features work. Ideally, I suppose, if parts of a module work on a platform, it would be included in the metadata, only the supported features would be tested on that platform, and the platform-specific caveats would be documented in the readme. But either way, a user could always investigate and use the module regardless of what's in the metadata, like what I am doing.