fix issue where single characters settings were not being saved. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you please add a test case for this, so we catch it in future changes? |
| @@ -6,7 +6,7 @@ module Util | |||
| class IniFile | |||
|
|
|||
| @@SECTION_REGEX = /^\s*\[([^\]]*)\]\s*$/ | |||
| @@SETTING_REGEX = /^(\s*)([^\[#;][\w\d\.\\\/\-\s\[\]\']*[\w\d\.\\\/\-\]])([ \t]*=[ \t]*)([\S\s]*?)\s*$/ | |||
| @@SETTING_REGEX = /^(\s*)([\w\d\.\\\/\-\s\[\]\']*[\w\d\.\\\/\-\]])([ \t]*=[ \t]*)([\S\s]*?)\s*$/ | |||
| @@COMMENTED_SETTING_REGEX = /^(\s*)[#;]+(\s*)([^\[]*[\w\d\.\\\/\-]+[\w\d\.\\\/\-\[\]\']+)([ \t]*=[ \t]*)([\S\s]*?)\s*$/ | |||
There was a problem hiding this comment.
Does @@COMMENTED_SETTING_REGEX have the same issue as @@SETTING_REGEX?
… setting also update @@COMMENTED_SETTING_REGEX to be roughly equal to "(\s*)[#;]+" + @@SETTING_REGEX
underscorgan
pushed a commit
that referenced
this pull request
Nov 6, 2014
fix issue where single characters settings were not being saved.
|
Thanks for the contribution @huan |
cegeka-jenkins
pushed a commit
to cegeka/puppet-inifile
that referenced
this pull request
Oct 23, 2017
fix issue where single characters settings were not being saved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see boxen/puppet-git#30