pdksync - (GH-iac-334) Remove Support for Ubuntu 14.04/16.04 #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasAud
previously approved these changes
Mar 23, 2022
The `git` prefix no longer works correctly with our setup and so has been swapped to `https`
Support for this has been dropped from the supported modules for some time, this one seems to have been missed in this process.
david22swan
changed the title
bastelfreak
requested changes
Mar 24, 2022
There was a problem hiding this comment.
https://github.com/puppetlabs/puppetlabs-docker/search?q=14.04 also here the module contains some 14.04/16.04 specific code and I really think that should be cleaned up in combination with the metadata.json remove of those operating systems. Otherwise it's really complicated in the future to determine if a change is a breaking change or not.
|
@bastelfreak This is just a quick automated pr to drop support, will be going through each module afterwards to remove compatibility. |
LukasAud
approved these changes
Mar 24, 2022
LukasAud
deleted the
pdksync_GH-iac-334/main/remove_ubuntu_16.04_support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(GH-iac-334) Remove Support for Ubuntu 16.04
pdk version:
2.1.0