Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker::stack refresh #657

Closed
wants to merge 1 commit into from
Closed

Conversation

kwek
Copy link

@kwek kwek commented Sep 11, 2020

Added 'refresh' possibility to docker::stack

@kwek kwek requested a review from a team as a code owner September 11, 2020 07:46
@puppet-community-rangefinder
Copy link

docker::stack is a type

that may have no external impact to Forge modules.

This module is declared in 7 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@kwek kwek mentioned this pull request Sep 11, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2020

Codecov Report

Merging #657 into main will decrease coverage by 3.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
- Coverage   25.64%   22.37%   -3.28%     
==========================================
  Files          20       20              
  Lines         741      751      +10     
==========================================
- Hits          190      168      -22     
- Misses        551      583      +32     
Impacted Files Coverage Δ
lib/facter/docker.rb 42.66% <0.00%> (-40.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4510ab1...05be785. Read the comment docs.

@adrianiurca
Copy link
Contributor

adrianiurca commented Sep 14, 2020

Hi @kwek, thank you for your contribution. The code looks good, but can you also add an acceptance test?
The acceptance test for stack refresh should be present in spec/acceptance/stack_spec.rb
Please let us know if you need any help.

kind regards,
@adrianiurca

@carabasdaniel
Copy link
Contributor

Hi @kwek,

As @adrianiurca mentioned before we usually merge PRs that have at least an acceptance tests confirming the functionality implemented, however as the docker stack define type will be deprecated in a future release could you probably try the docker_stack type/provider if it covers the functionality you need ?

Thanks!

@carabasdaniel carabasdaniel self-assigned this Nov 2, 2020
@carabasdaniel
Copy link
Contributor

Closing this PR due to lack of activity. Please feel free to re-open if the docker_stack provider does not cover this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants