(CLOUD-1560)-adding-functionality to remove systemd service files. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MWilsonPuppet this is looking good so far. Can you also update the unit tests so we have coverage of this? |
MWilsonPuppet
force-pushed
the
CLOUD-1560-removing-systemd-service-files
branch
3 times, most recently
from
c3e7a94 to
d22b54e
Compare
MWilsonPuppet
force-pushed
the
CLOUD-1560-removing-systemd-service-files
branch
from
d22b54e to
220b6a5
Compare
|
@davejrt Hey Dave I have added the spec and acceptance tests and updated the readme. |
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality so that when docker run is set to ensure => absent, the systemd service files are removed. I have verified that this works with single and multiple containers and it is working as expected.