Use standardized quote type to help tests pass #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DLeich Thanks for submitting the PR. |
|
@DLeich Could you please rebase with master. The fix for the unit tests are in the master. Thank you. |
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
=======================================
Coverage 28.02% 28.02%
=======================================
Files 19 19
Lines 685 685
=======================================
Hits 192 192
Misses 493 493Continue to review full report at Codecov.
|
|
Hi @DLeich, Thank you for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing the Onceover testing suite in a control repo which references this puppetlabs-docker module in its puppetfile, Onceover throws the following error for incorrect quote types.
ERROR -> ignoring invalid line in file: /var/lib/jenkins/workspace/CPSRE_puppet_production/.onceover/etc/puppetlabs/code/environments/production/modules/docker/manifests/stack.pp (invalid byte sequence in US-ASCII) - line: '# Only accepts (“always”|“changed”|“never”)This pull request changes the quote types to standardized ASCII form on the affected comment line.