Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let docker.service start docker services managed by puppetlabs/docker… #563

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

jhejl
Copy link

@jhejl jhejl commented Dec 23, 2019

Systemd units created by puppetlabs/docker defines the dependency on docker.service via Requires=docker.service stanza. This won't let docker-mycontainer.service service start unless docker.service is running.

From time to time there are situations where you stop docker.service (mostly due to docker upgrades / setup changes etc.).
apt-get upgrade (or you) will stop docker.service, systemd will take a care of stopping all services that states Requires=docker.service, docker is being upgraded and started. Unfortunately systemd won't boot up the docker-mycontainer.service as there's no dependency definition.

This PR introduces simple reverse dependency relation between docker container systemd units and docker.service.

@jhejl jhejl requested a review from a team as a code owner December 23, 2019 13:23
@codecov-io
Copy link

codecov-io commented Dec 23, 2019

Codecov Report

Merging #563 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #563   +/-   ##
=======================================
  Coverage   28.02%   28.02%           
=======================================
  Files          19       19           
  Lines         685      685           
=======================================
  Hits          192      192           
  Misses        493      493
Impacted Files Coverage Δ
lib/puppet/provider/docker_compose/ruby.rb 20.63% <0%> (ø) ⬆️
lib/puppet/provider/docker_stack/ruby.rb 24% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af994cc...ead63eb. Read the comment docs.

@sheenaajay
Copy link
Contributor

Thanks @jhejl for submitting the PR. Could you please add tests to verify the change. Thank you.

@sheenaajay
Copy link
Contributor

Screen Shot 2020-02-25 at 13 51 57

@sheenaajay
Copy link
Contributor

Thanks @jhejl for your contribution.

@sheenaajay sheenaajay merged commit 0196436 into puppetlabs:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants