Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase apt pin from 10 to 500 #425

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Conversation

baurmatt
Copy link
Contributor

As the default of this module is to install Docker from the offical
Docker repository, we should also configure the pin accordingly.

Fixes #424.

As the default of this module is to install Docker from the offical
Docker repository, we should also configure the pin accordingly.

Fixes puppetlabs#424.
@DavidS
Copy link
Contributor

DavidS commented Feb 12, 2019

This was originally added in garethr/garethr-docker#570 there is no mention of a specific reason for the low pin.

@baurmatt
Copy link
Contributor Author

Actually, this was originally introduced with garethr/garethr-docker#4. But there is also no reason given for that config :(

@binford2k
Copy link

Considering the latest Docker vulnerability, this might be worth fast-tracking.

https://seclists.org/oss-sec/2019/q1/119

@davejrt
Copy link
Contributor

davejrt commented Feb 12, 2019

LGTM

@davejrt davejrt merged commit cd4592d into puppetlabs:master Feb 12, 2019
@baurmatt
Copy link
Contributor Author

Can we please get a release which includes this fix? :)

@baurmatt baurmatt deleted the fix/apt_pin branch February 13, 2019 09:07
@davejrt davejrt added this to the 3.2.1 milestone Feb 13, 2019
@davejrt
Copy link
Contributor

davejrt commented Feb 13, 2019

@baurmatt 3.3.0 is now on the forge

@baurmatt
Copy link
Contributor Author

@davejrt Awesome, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants