Add Docker EE support for Windows Server 2016 #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mihaibuzgau this is a great start. Let's work on getting the unit and acceptance tests completed before we merge this into master though. |
|
@davejrt agreed. I'll add some unit and acceptance tests as soon as I get the chance. |
davejrt
reviewed
May 17, 2018
| @@ -0,0 +1,31 @@ | |||
| { | |||
| <%# TODO: get "authorization-plugins": [],%> | |||
There was a problem hiding this comment.
Can we remove any commented code, just so there's nothing WIP sitting in master?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality to deploy Docker Enterprise Edition on Windows Server 2016. The deployment is done using the Docker module available in the online Powershell gallery.
This PR also adds the functionality to deploy Docker images on Windows.