Limit Image -> Run dependencies to those used #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use searching in the resource collection to limit adding dependencies on Docker::Image for only those Docker::Run resources defined to use the specific image. This reduces the likelihood of accidental cyclical dependencies where consumers defined a manifest per service containing an image and run, and then try to add a dependency from one service class onto another. Fixes puppetlabs#640
Test that a Docker::Image resource can depend on an unrelated Docker::Run resource. This ensures that multiple classes making use of Docker::Image and Docker::Run resources for unrelated services may create simple dependencies between classes such as the following definition does not trigger a dependency cycle when both classes are in turn using Docker::Image & Docker::Run for unrelated images. Class['database'] -> Class['application']
|
Originally reported as garethr/garethr-docker#640 and submitted as garethr/garethr-docker#641 |
|
LGTM |
mihaibuzgau
added a commit
to mihaibuzgau/puppetlabs-docker
that referenced
this pull request
Jul 5, 2018
Limit Image -> Run dependencies to those used Merge pull request puppetlabs#202 from electrofelix/onlyif-running Add support for onlyif in a docker exec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use searching in the resource collection to limit adding dependencies on
Docker::Image for only those Docker::Run resources defined to use the
specific image.
This reduces the likelihood of accidental cyclical dependencies where
consumers defined a manifest per service containing an image and run,
and then try to add a dependency from one service class onto another.