Allow ssl_certs_dir to be unset. #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases we don't want SSLCACertificatePath to be set at all. If we're using SSLCACertificateFile instead to verify clients we might want that to be the only CA used. Most other options in this template are optional, so I don't see why this one can't be too.
apenney
pushed a commit
that referenced
this pull request
Jul 3, 2014
Allow ssl_certs_dir to be unset.
underscorgan
pushed a commit
to underscorgan/puppetlabs-apache
that referenced
this pull request
Nov 7, 2014
The SSLCACertificatePath is always set. The check for @ssl_certs_dir only covers "undef". As there is a default value in ::apache::params for ssl_certs_dir it needs to be overriden with an empty string. Right now the _ssl.erb template outputs 'SSLCACertificatePath ""' for an empty string, which triggers a failing reload of httpd. This patch just adds a "&& @ssl_certs_dir != ''" to the condition. On a Puppet master passenger vhost it's probably security relevant setting, as it enables all system CA signed certificates access. Related patch: puppetlabs#787
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
Fix missing comma in docker::image example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases we don't want SSLCACertificatePath to be set at all. If we're using SSLCACertificateFile instead to verify clients we might want that to be the only CA used. Most other options in this template are optional, so I don't see why this one can't be too.