Replace legacy bool2httpd() function with shim
#2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the legacy `lib/puppet/parser/functions/bool2httpd.rb` function with a 4.x API shim function that calls the namespaced `apache::bool2httpd` function. The shim might not actually be necessary as the function is probably `private`. The non-namespaced legacy version was still being used in a few instances in templates. This has been corrected.
ekohl
approved these changes
May 2, 2020
david22swan
approved these changes
May 5, 2020
cegeka-jenkins
pushed a commit
to cegeka/puppet-apache
that referenced
this pull request
Jul 15, 2020
…l2httpd Replace legacy `bool2httpd()` function with shim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the legacy
lib/puppet/parser/functions/bool2httpd.rbfunction with a 4.x API shimfunction that calls the namespaced
apache::bool2httpdfunction.The shim might not actually be necessary as the function is probably
private.The non-namespaced legacy version was still being used in a few
instances in templates. This has been corrected.