Tidy up pw_hash function
#2024
Merged
Tidy up pw_hash function
#2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove legacy non-namespaced `lib/puppet/parser/functions/apache_pw_hash.rb` * Create 4x API non-namespaced `apache_pw_hash` shim that calls `apache::pw_hash` * Rename existing 4x API `apache::apache_pw_hash` to `apache::pw_hash` * Create shim for `apache::apache_pw_hash` that calls `apache::pw_hash` * Mark shims as DEPRECATED * Test all 3 versions work
Codecov Report
@@ Coverage Diff @@
## master #2024 +/- ##
==========================================
- Coverage 57.87% 53.46% -4.41%
==========================================
Files 13 14 +1
Lines 235 245 +10
==========================================
- Hits 136 131 -5
- Misses 99 114 +15
Continue to review full report at Codecov.
|
ekohl
approved these changes
May 2, 2020
david22swan
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/puppet/parser/functions/apache_pw_hash.rbapache_pw_hashshim that callsapache::pw_hashapache::apache_pw_hashtoapache::pw_hashapache::apache_pw_hashthat callsapache::pw_hash