Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an apache::vhost::fragment define #1980

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Dec 4, 2019

The apache::vhost::fragment define allows adding fragments to an existing vhost. This is easier than using the custom_fragment property, especially when one class defines the vhost and another class wants to add add some content to that.

This work was inspired by #1659.

@ekohl ekohl requested a review from a team as a code owner December 4, 2019 15:13
The apache::vhost::fragment define allows adding fragments to an
existing vhost. This is easier than using the custom_fragment property,
especially when one class defines the vhost and another class wants to
add add some content to that.
Copy link
Collaborator

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@DavidS DavidS added the feature label Dec 16, 2019
@DavidS DavidS merged commit 36501a6 into puppetlabs:master Dec 16, 2019
@ekohl ekohl deleted the vhost-fragment branch December 16, 2019 10:31
cegeka-jenkins pushed a commit to cegeka/puppet-apache that referenced this pull request Jul 15, 2020
Add an apache::vhost::fragment define
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants