Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility to define variables inside VirtualHost definition #1947

Merged
merged 1 commit into from
Sep 16, 2019
Merged

add possibility to define variables inside VirtualHost definition #1947

merged 1 commit into from
Sep 16, 2019

Conversation

trefzer
Copy link
Contributor

@trefzer trefzer commented Sep 10, 2019

The variable can them be used inside the vhost tag as a variable.
At the footer, the variable is undefined to avoid side effects
in other vhosts.

also see https://httpd.apache.org/docs/2.4/mod/core.html#define

The variable can them be used inside the vhost tag as a variable.
At the footer, the variable is undefined to avoid side effects
in other vhosts.

also see https://httpd.apache.org/docs/2.4/mod/core.html#define
Copy link
Contributor

@tphoney tphoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @trefzer thanks for the PR. this indeed looks like a useful addition to vhost.

  • $define does not feel like a good variable name
  • definitely needs example usage, along with the text you provided
  • an acceptance test showing that it works as intended.

Thanks again for this. Have a good one !

@trefzer
Copy link
Contributor Author

trefzer commented Sep 11, 2019

@tphoney
I agree, that $define is not optimal, but it's the same as in the config file which make's it easy to read. But I did not find any better name, I'm verry open for suggestions.

about examples, I think the link in the apache docs is quite clear. But I can add a simple example.

@tphoney
Copy link
Contributor

tphoney commented Sep 16, 2019

A fair point well made, i have to ask :)

Thanks for the great PR, have a good one !

@tphoney tphoney merged commit 49c1ebe into puppetlabs:master Sep 16, 2019
@trefzer trefzer deleted the dev_cirrax branch September 18, 2019 14:27
cegeka-jenkins pushed a commit to cegeka/puppet-apache that referenced this pull request Jul 15, 2020
add possibility to define variables inside VirtualHost definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants