Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FM-8393) add support on Debian 10 #1945

Merged
merged 4 commits into from
Sep 12, 2019

Conversation

ThoughtCrhyme
Copy link
Contributor

I cherry picked the changes from #1932 which contain the sshkey fixes from 6054786

@ekohl
Copy link
Collaborator

ekohl commented Sep 9, 2019

I don't mind rebasing my PR if that makes the tests green.

@ThoughtCrhyme
Copy link
Contributor Author

@ekohl for sure, if you want to rebase your changes on master you'll pull in the ssh fix. I'm fine either way, and want to make sure you get the credit for adding the fix. Thanks!

@lionce
Copy link
Contributor

lionce commented Sep 10, 2019

@lionce lionce added the feature label Sep 10, 2019
@martialblog
Copy link

I can confirm this PR works for Debian 10, just tested it. Would love to see this merged and in the Forge :shipit:

@lionce lionce changed the title (FM-8393) use ekohl's fix for php 7.3 on Debian 10 (FM-8393) add support on Debian 10 Sep 12, 2019
@lionce lionce merged commit 496a9f8 into puppetlabs:master Sep 12, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-apache that referenced this pull request Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants