Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shibboleth support for Debian 10 #1939

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Add shibboleth support for Debian 10 #1939

merged 1 commit into from
Sep 16, 2019

Conversation

fabbks
Copy link

@fabbks fabbks commented Aug 28, 2019

Debian renamed the shib library to mod_shib.so in Debian 10 (buster) so mod shibboleth won't load anymore. This PR fixes that.

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this break Ubuntu?

@fabbks
Copy link
Author

fabbks commented Sep 2, 2019

I'm not an Ubuntu user but this seems to be true. I changed the condition to make it Ubuntu and Debian version specific.

@sheenaajay
Copy link
Contributor

Thanks for submitting the PR @fabbks.Could you please rebase with the latest master.Thank you.
Screen Shot 2019-09-13 at 11 30 23

@fabbks
Copy link
Author

fabbks commented Sep 13, 2019

Done!

@sheenaajay sheenaajay merged commit f468aae into puppetlabs:master Sep 16, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-apache that referenced this pull request Jul 15, 2020
Add shibboleth support for Debian 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants