Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-9014) Improve SSLSessionTickets handling #1923

Merged
merged 1 commit into from
May 16, 2019

Conversation

FredL69
Copy link

@FredL69 FredL69 commented May 15, 2019

  • Make ssl_sessiontickets parameter optional
  • Set default value for ssl_sessiontickets to undef (Compatible
    with all Apache versions)
  • Update documentation and unit tests accordingly

@sheenaajay Here the the pull request with the fixes you expected. ssl_sessiontickets is now optional with the default value set to undef. So, by default, the parameter will not be set and nothing will break on older distributions. Moreover it simplifies the code, which is always a good thing.

- Make ssl_sessiontickets parameter optional
- Set default value for ssl_sessiontickets to undef (Compatible
  with all Apache versions)
- Update documentation and unit tests accordingly
@sheenaajay
Copy link
Contributor

@FredericLespez Wow looks good. Running the acceptance tests on different platforms. Thank you

@FredL69
Copy link
Author

FredL69 commented May 15, 2019

@sheenaajay Test failed but apparently not because of the submitted code:
centos-7-x64 12:44:59$ rpm --replacepkgs -Uvh http://yum.puppet.com/puppet6/puppet6-release-el-7.noarch.rpm
curl: (22) The requested URL returned error: 404 Not Found
error: skipping http://yum.puppet.com/puppet6/puppet6-release-el-7.noarch.rpm - transfer failed
Retrieving http://yum.puppet.com/puppet6/puppet6-release-el-7.noarch.rpm

The right URL is http://yum.puppet.com/puppet6-release-el-7.noarch.rpm.
Do you know of to fix that ?

@sheenaajay
Copy link
Contributor

@FredericLespez No worries.Its centos7 issues(rpm link is invalid).We are working on the problem. Hopefully will resolve it soon. All the rest of the platforms passed also. Will merge it as soon as ceentos7 problems are fixed from our side.Thanks for the quick fix.

@sheenaajay
Copy link
Contributor

@FredericLespez centos errors are fixed. Restarted the build. Will merge it as soon as its finished running.

@sheenaajay sheenaajay merged commit 2ca52bf into puppetlabs:master May 16, 2019
@FredL69
Copy link
Author

FredL69 commented May 16, 2019

@sheenaajay That's great! Thanks.

@FredL69 FredL69 deleted the SSLSessionTicketsV2 branch May 16, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants