Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FM-7923) Implement Puppet Strings #1916

Merged
merged 29 commits into from
May 7, 2019
Merged

Conversation

eimlav
Copy link
Contributor

@eimlav eimlav commented May 1, 2019

The following changes add a REFERENCE.md file generated by Puppet Strings.

This PR takes over for the work done by @david22swan in #1911 as he is no longer working on this module.

@eimlav eimlav added the feature label May 1, 2019
@eimlav eimlav force-pushed the FM-7923 branch 2 times, most recently from e9e97f4 to db05102 Compare May 1, 2019 12:52
@eimlav eimlav requested a review from clairecadman May 2, 2019 10:59
README.md Outdated Show resolved Hide resolved
@tphoney
Copy link
Contributor

tphoney commented May 2, 2019

👍 from me,

@eimlav eimlav changed the title [WIP] (FM-7923) Implement Puppet Strings (FM-7923) Implement Puppet Strings May 3, 2019
@sheenaajay sheenaajay merged commit 98cf15c into puppetlabs:master May 7, 2019
youeyoue added a commit to youeyoue/puppetlabs-apache that referenced this pull request May 7, 2019
Resolved conflict with upstream README.md (PR puppetlabs#1916)
Moved parameter documentation to module to stay in line with puppet strings
sheenaajay pushed a commit that referenced this pull request May 9, 2019
* MODULES-9003 Parameterize location for ldap-status

Add ldap_path parameter to apache::mod::ldap with
Change ldap.conf.erb to use new parameter
Add new parameter to README.md

* (MODULES-9003) Parameterize location for ldap-status

Resolved conflict with upstream README.md (PR #1916)
Moved parameter documentation to module to stay in line with puppet strings

* (MODULES-9003) Parameterize location for ldap-status

Add regex unit test for Location block and custom ldap_path
cegeka-jenkins pushed a commit to cegeka/puppet-apache that referenced this pull request Jul 15, 2020
* (FM-7923) - Implement Puppet Strings.
Authors: 
 David Swan [email protected]
 Eimhin Laverty [email protected]
 Claire Cadman [email protected]
cegeka-jenkins pushed a commit to cegeka/puppet-apache that referenced this pull request Jul 15, 2020
* MODULES-9003 Parameterize location for ldap-status

Add ldap_path parameter to apache::mod::ldap with
Change ldap.conf.erb to use new parameter
Add new parameter to README.md

* (MODULES-9003) Parameterize location for ldap-status

Resolved conflict with upstream README.md (PR puppetlabs#1916)
Moved parameter documentation to module to stay in line with puppet strings

* (MODULES-9003) Parameterize location for ldap-status

Add regex unit test for Location block and custom ldap_path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants