Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Add HTML anchor tag #1863

Merged
merged 2 commits into from
Dec 21, 2018
Merged

(maint) Add HTML anchor tag #1863

merged 2 commits into from
Dec 21, 2018

Conversation

clairecadman
Copy link
Contributor

The anchor tag helps fix broken links — If the header text changes (gets localized) the link will brake.

README.md Outdated
@@ -720,6 +726,7 @@ apache::mod { 'mod_authnz_external': }

There are several optional parameters you can specify when defining Apache modules this way. See the [defined type's reference][`apache::mod`] for details.

<a id="configuring-fastCGI-servers"></a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are labels case sensitive? Should this be all lowercase?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ehom ehom Dec 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @clairecadman

Line 17:

[Configuring FastCGI servers]: #configuring-fastcgi-servers-to-handle-php-files

So, this would be the correct anchor:

<a id="configuring-fastcgi-servers-to-handle-php-files"></a>

To test, just modify the section header a little bit

### Configuring FastCGI servers to handle PHP files xxxxxxxxx

Copy link
Contributor

@ehom ehom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<a id="configuring-fastcgi-servers-to-handle-php-files"></a>

Copy link
Contributor

@ehom ehom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmcmaw
Copy link
Contributor

pmcmaw commented Dec 21, 2018

Closing and reopening to rekick Travis to remove failures.

@pmcmaw pmcmaw closed this Dec 21, 2018
@pmcmaw pmcmaw reopened this Dec 21, 2018
@tphoney tphoney merged commit 13ad56f into master Dec 21, 2018
@david22swan david22swan deleted the anchor-tags branch March 26, 2019 10:30
cegeka-jenkins pushed a commit to cegeka/puppet-apache that referenced this pull request Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants