adjust params and mpm to recent FreeBSD packages #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,10 +13,7 @@ | |||
| $_path = "${lib_path}/${_lib}" | |||
| $_id = "mpm_${mpm}_module" | |||
|
|
|||
| if versioncmp($apache_version, '2.4') >= 0 and | |||
| (($::osfamily != 'FreeBSD') or | |||
| ($::osfamily == 'FreeBSD' and $mpm == 'itk')) { | |||
There was a problem hiding this comment.
bit confused what this was supposed to check anyway…
underscorgan
pushed a commit
that referenced
this pull request
Feb 18, 2015
adjust params and mpm to recent FreeBSD packages
|
Thanks @mmoll ! |
|
@sethlyons I am adding a note in the 1.4.0 CHANGELOG pointing to the conversation here if users are on < 2.4.12 with FreeBSD. |
|
@mhaskel thanks! sorry i haven't yet had a chance to update the readme. do you still want me to do that? |
|
@sethlyons up to you. Will merge README updates if you want them :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change I can use theforeman/puppet to setup a Puppet master under Passenger on FreeBSD.