Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PUP-9050) Beaker 4.0 Compatibility #6984

Closed
wants to merge 4 commits into from
Closed

Conversation

Dakta
Copy link
Contributor

@Dakta Dakta commented Aug 9, 2018

Assorted minor changes for Beaker 4.0 compatibility.

@Dakta Dakta added blocked PRs blocked on work external to the PR itself Do Not Merge labels Aug 9, 2018
@Dakta Dakta requested a review from melissa August 9, 2018 18:55
Beaker 4.0 drops implicit inclusion of hypervisors, so dependent projects need to specify their hypervisor dependencies manually.
Beaker-vcloud dropped support for silently upgrading vcloud-pooled type hosts to vmpooler, so these host configurations have been upgraded to use vmpooler.
@melissa
Copy link
Contributor

melissa commented Aug 9, 2018

I believe we're going to want this in the oldest supported branch, which I believe at this point is 5.5.x? I think 4.10.x and 5.3.x are both in deep maintenance mode atm

cc/ @joshcooper @jhelwig

gem "beaker-hostgenerator", *location_for(ENV['BEAKER_HOSTGENERATOR_VERSION'] || "~> 1.1")
gem "beaker-abs", *location_for(ENV['BEAKER_ABS_VERSION'] || "~> 0.4")
gem "beaker-vmpooler", *location_for(ENV['BEAKER_VMPOOLER_VERSION'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should pin this to a particular version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Dakta Dakta removed blocked PRs blocked on work external to the PR itself Do Not Merge labels Aug 10, 2018
@Dakta Dakta changed the title (BKR-1509) Beaker 4.0 Compatibility (PUP-9050) Beaker 4.0 Compatibility Aug 10, 2018
@puppetlabs puppetlabs deleted a comment from puppetcla Aug 10, 2018
@Dakta
Copy link
Contributor Author

Dakta commented Aug 10, 2018

Closing in favor of #6988, due to changed maintenance branch target.

@Dakta Dakta closed this Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants