Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PUP-8495) Systemd support, Ubuntu 17.04 and 17.10 #6706

Merged
merged 1 commit into from
Mar 14, 2018

Conversation

kbarmen
Copy link
Contributor

@kbarmen kbarmen commented Mar 2, 2018

This is a trivial patch that adds support for Ubuntu 17.04 and 17.10.

This is a trivial patch that adds support for Ubuntu 17.04 and 17.10.
@puppetlabs-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@puppetcla
Copy link

Waiting for CLA signature by @kbarmen

@kbarmen - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

@kbarmen
Copy link
Contributor Author

kbarmen commented Mar 5, 2018

This is very trivial, no CLA needed.

@melissa melissa self-assigned this Mar 5, 2018
@melissa
Copy link
Contributor

melissa commented Mar 9, 2018

Hi! I apologize this is taking so long on my end. I'm waiting on some resources from IT before I can move forward with this, but hopefully I'll have what I need before too long.

@michaeljs1990
Copy link

michaeljs1990 commented Mar 13, 2018

Can we add 18.04 as well since that will also need this and is currently available to pull from Canonical?

@kbarmen
Copy link
Contributor Author

kbarmen commented Mar 13, 2018

Indeed - a more permanent and correct solution is to make systemd default for both Debian and Ubuntu, and leave the old behaviour for just the legacy releases.

@michaeljs1990
Copy link

Yeah if versioning allows something like ">= 15.04" that would be awesome but I think would make this diff a bit more work.

@jkroepke
Copy link
Contributor

@kbarmen Can you add 18.04, too?

@melissa
Copy link
Contributor

melissa commented Mar 14, 2018

You're welcome to add 18.04 if you like, or we can open a new PR for it. Please note that because we are adding these OS's here does not mean we will be creating packages for them. That is handled by a seperate set of automation. You can see tickets for 17.04 at https://tickets.puppetlabs.com/browse/PA-873 (it looks like that's not happening at all), and 18.04 at https://tickets.puppetlabs.com/browse/PA-1869. I couldn't find anything for 17.10.

@jkroepke
Copy link
Contributor

@melissa For the moment Debian 9 packages are working fine for Ubuntu 18.04

@melissa
Copy link
Contributor

melissa commented Mar 14, 2018

Also, unfortunately the defaultfor mechanism requires an array of values. I haven't dug into it too much, but there are no existing examples where we defined something like >= 15.05. I agree it would be very nice to be able to do that.

@jhelwig jhelwig merged commit 65703e4 into puppetlabs:4.10.x Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants