Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) make test order really random #175

Merged
merged 3 commits into from
Jun 17, 2019
Merged

(maint) make test order really random #175

merged 3 commits into from
Jun 17, 2019

Commits on Jun 13, 2019

  1. (maint) make test order really random 

    The test leakage fixed in the previous commit was only detected by
changing the test order. Removing the seed will ensure that different
test orderings are tested, leading to a more robust test suite as new
issues are discovered and fixed.
    @DavidS
    DavidS committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    7554c2f View commit details
    Browse the repository at this point in the history

  2. (maint) reset provider cache between tests 

    Without this the `provider` mock would leak between tests.
    @DavidS
    DavidS committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    6448423 View commit details
    Browse the repository at this point in the history

  3. (maint) reset warning count after testing filtering 

    After each of those test, the `warning_count` was 100 and other
tests for warnings would fail as they would have been swallowed.
    @DavidS
    DavidS committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    74559e0 View commit details
    Browse the repository at this point in the history